Skip to content

Don't get a Field object for every Addon #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olliestanley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't get a Field object for every Addon #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/main/java/org/obsidianbox/obsidian/addon/CommonAddonManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,25 @@ public class CommonAddonManager implements AddonManager {
private final SerializableHashMap addonMD5s = new SerializableHashMap();
private final Addon internal;

private Field gameField;
private Field descriptionField;
private Field loggerField;
private Field dataPathField;

public CommonAddonManager(Game game) {
this.game = game;
this.internal = new InternalAddon(game);
addons.add(internal);

Class<Addon> clazz = Addon.class;
try {
gameField = clazz.getDeclaredField("game");
descriptionField = clazz.getDeclaredField("description");
loggerField = clazz.getDeclaredField("logger");
dataPathField = clazz.getDeclaredField("dataPath");
} catch (NoSuchFieldException e) {
e.printStackTrace();
}
}

@Override
Expand Down Expand Up @@ -103,22 +118,18 @@ public Addon loadAddon(Path path) throws InvalidAddonException, InvalidDescripti
final Constructor<? extends Addon> constructor = addonClass.getConstructor();
final Addon addon = constructor.newInstance();

final Field gameField = addonClass.getSuperclass().getDeclaredField("game");
gameField.setAccessible(true);
gameField.set(addon, game);
gameField.setAccessible(false);

final Field descriptionField = addonClass.getSuperclass().getDeclaredField("description");
descriptionField.setAccessible(true);
descriptionField.set(addon, description);
descriptionField.setAccessible(false);

final Field loggerField = addonClass.getSuperclass().getDeclaredField("logger");
loggerField.setAccessible(true);
loggerField.set(addon, LogManager.getLogger(description.getName()));
loggerField.setAccessible(false);

final Field dataPathField = addonClass.getSuperclass().getDeclaredField("dataPath");
dataPathField.setAccessible(true);
dataPathField.set(addon, dataPath);
dataPathField.setAccessible(false);
Expand Down