Allowing HTML attributes with _ as the first character in the name (#355)#356
Open
slickdomi wants to merge 1 commit intoOWASP:mainfrom
Open
Allowing HTML attributes with _ as the first character in the name (#355)#356slickdomi wants to merge 1 commit intoOWASP:mainfrom
slickdomi wants to merge 1 commit intoOWASP:mainfrom
Conversation
slickdomi
changed the title
aalmiray
force-pushed
the
main
branch
6 times, most recently
from
9bb458a to
f40152f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the condition in the HtmlStreamRenderer.isValidHtmlName for
_to not consider it invalid if it's the first character of the name. I also added a unit test that checks this case.Fix for issue #355