-
-
Notifications
You must be signed in to change notification settings - Fork 50
Implement Cross-Platform PDF Generation without MS Word dependency #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
sydseter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at my comments. Thank you for your efforts!
|
Remember to make sure you run the tests before pushing your commits. |
|
nc |
|
Hi @sydseter , Please review my PR and let me know if any further changes are needed. |
|
I will need some time to test it out. I'll get back to you. |
|
This works quite well. It would be great if we also could do a couple of the following things:
|
|
Yes, that makes sense. I’ll add LibreOffice installation instructions to scripts/README.md |
|
Hi @sydseter , Take a final look ,I have updated LibreOffice installation instructions . Let me know if any further changes are needed. |
| # install build dependencies | ||
| RUN apt-get update -y && apt-get install -y build-essential git nodejs npm \ | ||
| && apt-get clean && rm -f /var/lib/apt/lists/*_* | ||
| RUN apt-get update -y && (apt-get install -y build-essential git nodejs npm || (sleep 10 && apt-get update -y && apt-get install -y build-essential git nodejs npm)) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why installing these packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is work on the converter it’s better not to do fixes on copi. If you believe this could be an improvement open an issue and explain why you believe we should do these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened a separate issue proposing this as an improvement, with an explanation of why it could be useful.
| # - Ex: hexpm/elixir:1.14.2-erlang-25.1.1-debian-bullseye-20220801-slim | ||
| # | ||
| FROM --platform=linux/amd64 hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 as builder | ||
| FROM hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe revert this?
|
|
||
| Cornucopia is developed, maintained, updated and promoted by a worldwide team of volunteers. The contributors to date have been: | ||
|
|
||
| - Abhijit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also add your full name. Your choice.
| # start a new build stage so that the final image will only contain | ||
| # the compiled release and other runtime necessities | ||
| FROM --platform=linux/amd64 hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 | ||
| FROM hexpm/elixir:1.19-erlang-28.3-debian-bullseye-20251208@sha256:9d1e59c326674de89a2eac9cd7f118ae2917e1c6cde02e8fa4cd785198ca9be0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be done together with the retry mechanism, but not here.
Key Changes
PDF Conversion Engine:-
Template Migration:-
Script Robustness:-
Cleanup and Performance:-
Issue:-#2110 – Implement Cross-Platform PDF Generation without MS Word dependency
