Conversation
|
| */ | ||
| xdrproc_t XDRUtils::xdr_coder(const Type &t) { | ||
| switch (t) { | ||
| A_cast_function_type_mismatch switch (t) { |
There was a problem hiding this comment.
I found "A_cast_function_type_mismatch" is defined at diagnostic_supporession.h
as ```
#define A_cast_function_type_mismatch
It is not obvious what it is doing. Could you add a comment to explain what it is doing or point to diagnostic_suppression.h for further reference.
There was a problem hiding this comment.
Right. I'll do that.
| } | ||
|
|
||
| return NULL; | ||
| A_Pop return nullptr; |
There was a problem hiding this comment.
Same comment as the above for A_pop.
| BaseType *bt = fs.var("fsab"); | ||
| CPPUNIT_ASSERT(bt); | ||
| Array *fsarr_p = dynamic_cast<Array *>(bt); | ||
| auto *fsarr_p = dynamic_cast<Array *>(bt); |
There was a problem hiding this comment.
Why here it is auto * but in line 984, it is auto?
| CPPUNIT_ASSERT(ui16_p); | ||
| CPPUNIT_ASSERT(ui16_p->value() == ui16->value()); | ||
| Url *url_p = dynamic_cast<Url *>((*row_sub)[1]); | ||
| auto *url_p = dynamic_cast<Url *>((*row_sub)[1]); |
There was a problem hiding this comment.
I still don't understand why not using" auto" rather than "auto *".
There was a problem hiding this comment.
I agree, maybe I should clean that up. It would be more consistent. Either is correct syntax and they mean the same thing, but for consistency, it would be better to always use one syntax.
3 participants
I fixed a number of warning in the libdap4 repo's code.