BES-99: Add GithubAction to build hyrax-builder images on manual trigger in CI#101
BES-99: Add GithubAction to build hyrax-builder images on manual trigger in CI#101hannahilea merged 14 commits intomasterfrom
hyrax-builder images on manual trigger in CI#101Conversation
hyrax-builder images on manual trigger in CIhyrax-builder images on manual trigger in CI
| # schedule: | ||
| # # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onschedule | ||
| # # Run on the first minute of the third hour, every day | ||
| # - cron: '0 3 * * *' | ||
| # push: | ||
| # branches: | ||
| # - master | ||
| # - main | ||
| # - /^(.*-test-deploy)$/ |
There was a problem hiding this comment.
I'm adding this here so that in #100 we can "flip the switch" by uncommenting them.
There was a problem hiding this comment.
I'm not remembering how I came to be installing that... It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....
|
|
||
| # Unable to locate package libimath-dev | ||
| # RUN set -e \ | ||
| # && apt-get install -y libimath-dev |
There was a problem hiding this comment.
I don't know if this is/will be a problem, but the ubuntu image wouldn't build with it...
Do we actually use the ubuntu image? If so, I'm curious about how it managed to build successfully last time.
There was a problem hiding this comment.
I'm not remembering how I came to be installing that... It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....
If that's the case, okay if I go ahead and merge without putting it back in? Or do you want to test something first? We wouldn't be tagging a new "latest" until testing the generated snapshot, regardless.
Also, we didn't previously have any ubuntu builder images: I had to create that Docker Hub repo for it manually. So I'm not sure we use this image anywhere?? (If that's wrong, maybe it had a different name before?) And if we don't use it, we probably shouldn't be building it? Curious and curiouser!
It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....
If this hyrax-builder image has items for building the olfs that are not otherwise used by the bes, that might be a good sign that our docker bes build should NOT use this as a base image, and should instead install just the few deps it needs.
There was a problem hiding this comment.
I think this ubuntu builder was a thing I did, but that doesn't mean it wasn't just a random
walk through the woods. I think it's fine not to include it in the GHA
There was a problem hiding this comment.
Cool---I'll remove it from the GHA (we can easily add it back later if desired) but not remove it from the repo outright general. (With the caveat, of course, that if it isn't in CI and we aren't building it regularly, it could experience bit rot.)
ndp-opendap
left a comment
There was a problem hiding this comment.
I had some questions, and I was unable to answer yours 🥇
| RUN export BUILD_DATE=`date +%s` | ||
| RUN echo "# BUILD_DATE: ${BUILD_DATE}" | ||
|
|
||
| RUN cat /etc/rocky-release | grep -Eo '[0-9]+(\.[0-9]+){0,}' > OS_VERSION |
| RUN export BUILD_DATE=`date +%s` | ||
| RUN echo "# BUILD_DATE: ${BUILD_DATE}" | ||
|
|
||
| RUN cat /etc/rocky-release | grep -Eo '[0-9]+(\.[0-9]+){0,}' > OS_VERSION |
There was a problem hiding this comment.
Where does OS_VERSION get used??
There was a problem hiding this comment.
In the accompanying github action, so that we can tag the built image with the version number
| # schedule: | ||
| # # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onschedule | ||
| # # Run on the first minute of the third hour, every day | ||
| # - cron: '0 3 * * *' | ||
| # push: | ||
| # branches: | ||
| # - master | ||
| # - main | ||
| # - /^(.*-test-deploy)$/ |
There was a problem hiding this comment.
I'm not remembering how I came to be installing that... It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....
Implement #99.
After build: