Skip to content

BES-99: Add GithubAction to build hyrax-builder images on manual trigger in CI#101

Merged
hannahilea merged 14 commits intomasterfrom
hr/hyrax-builder-in-ci
Feb 6, 2026
Merged

BES-99: Add GithubAction to build hyrax-builder images on manual trigger in CI#101
hannahilea merged 14 commits intomasterfrom
hr/hyrax-builder-in-ci

Conversation

@hannahilea
Copy link
Contributor

@hannahilea hannahilea commented Feb 3, 2026

Implement #99.

After build:

  • Communicate with rest of team so everyone knows how to trigger a manual GHA

@hannahilea hannahilea changed the title #BES-99: Add GithubAction to build hyrax-builder images on manual trigger in CI BES-99: Add GithubAction to build hyrax-builder images on manual trigger in CI Feb 3, 2026
Comment on lines +7 to +15
# schedule:
# # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onschedule
# # Run on the first minute of the third hour, every day
# - cron: '0 3 * * *'
# push:
# branches:
# - master
# - main
# - /^(.*-test-deploy)$/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding this here so that in #100 we can "flip the switch" by uncommenting them.

Copy link
Collaborator

@ndp-opendap ndp-opendap Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not remembering how I came to be installing that... It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....


# Unable to locate package libimath-dev
# RUN set -e \
# && apt-get install -y libimath-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is/will be a problem, but the ubuntu image wouldn't build with it...

Do we actually use the ubuntu image? If so, I'm curious about how it managed to build successfully last time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not remembering how I came to be installing that... It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....

If that's the case, okay if I go ahead and merge without putting it back in? Or do you want to test something first? We wouldn't be tagging a new "latest" until testing the generated snapshot, regardless.

Also, we didn't previously have any ubuntu builder images: I had to create that Docker Hub repo for it manually. So I'm not sure we use this image anywhere?? (If that's wrong, maybe it had a different name before?) And if we don't use it, we probably shouldn't be building it? Curious and curiouser!

It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....

If this hyrax-builder image has items for building the olfs that are not otherwise used by the bes, that might be a good sign that our docker bes build should NOT use this as a base image, and should instead install just the few deps it needs.

Copy link
Collaborator

@ndp-opendap ndp-opendap Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this ubuntu builder was a thing I did, but that doesn't mean it wasn't just a random
walk through the woods. I think it's fine not to include it in the GHA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool---I'll remove it from the GHA (we can easily add it back later if desired) but not remove it from the repo outright general. (With the caveat, of course, that if it isn't in CI and we aren't building it regularly, it could experience bit rot.)

Copy link
Collaborator

@ndp-opendap ndp-opendap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions, and I was unable to answer yours 🥇

RUN export BUILD_DATE=`date +%s`
RUN echo "# BUILD_DATE: ${BUILD_DATE}"

RUN cat /etc/rocky-release | grep -Eo '[0-9]+(\.[0-9]+){0,}' > OS_VERSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ibid.

RUN export BUILD_DATE=`date +%s`
RUN echo "# BUILD_DATE: ${BUILD_DATE}"

RUN cat /etc/rocky-release | grep -Eo '[0-9]+(\.[0-9]+){0,}' > OS_VERSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does OS_VERSION get used??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the accompanying github action, so that we can tag the built image with the version number

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +7 to +15
# schedule:
# # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onschedule
# # Run on the first minute of the third hour, every day
# - cron: '0 3 * * *'
# push:
# branches:
# - master
# - main
# - /^(.*-test-deploy)$/
Copy link
Collaborator

@ndp-opendap ndp-opendap Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not remembering how I came to be installing that... It might have been lifted from the Ubuntu set up that TravisCI uses to run the check and distcheck targets for the OLFS or BES....

@hannahilea hannahilea merged commit 364db3d into master Feb 6, 2026
3 checks passed
@hannahilea hannahilea deleted the hr/hyrax-builder-in-ci branch February 6, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants