NgapBuildDmrppContainer lifecycle changes from lcfo-2023#867
NgapBuildDmrppContainer lifecycle changes from lcfo-2023#867ndp-opendap wants to merge 1 commit intomasterfrom
Conversation
|
|
|
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
I think this can be merged. It seems to have languished, but if it's still valid, then lets merge it. Otherwise, let's close this PR.
|
@ndp-opendap What is the status of this PR? Should it be merged or dropped? |
|
It was never review. It's possible this idea is worthy, or it may be junk. Given the c++ situation in general this would require careful review |
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
Lets drop this or review it, merge master to it, etc.
2 participants
This is an attempt to stop the container from hanging onto a shared pointer to an object which keeps a file open until the next request.
Imported lifecycle changes for
NgapBuildDmrppContainerfromlcfo-2023It is entirely possible that this attempt is just wrong. At the point I wonder if we couldn't just get the container at the end of the transmission and call release() on the shared_ptr