Fix the AT_BESCMD_BINARY_DAP4_RESPONSE_TEST test macro for OSX Intel and Apple silicon#1252
Merged
jgallagher59701 merged 5 commits intomasterfrom Feb 4, 2026
Merged
Conversation
hannahilea
reviewed
Feb 4, 2026
| # if the tests are running on Apple silicon, use the *.mproc baseline, | ||
| # otherwise use the plain baseline. jhrg 2/3/26 | ||
| echo "uname -m: $(uname -m)" | ||
| AS_IF([ test "x$(uname -m)" = "xarm64" -a -f $baseline.m_proc], |
Contributor
There was a problem hiding this comment.
Out of curiosity, because I've also seen it elsewhere in our codebase: what is the reason for prefixing the various comparison strings with an x? e.g., why
"x$(uname -m)" = "xarm64"
instead of
"$(uname -m)" = "arm64"
?
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reference ticket: HYRAX-2009
Fix the AT_BESCMD_BINARY_DAP4_RESPONSE_TEST test macro for OSX Intel and Apple silicon
Tasks