[18.0][MIG] sale_margin_delivered_security: Migration to 18 #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_margin_delivered_security
Following OCA/product-attribute#1538, the security is now done via mixin and the view can be removed. @moduon MT-5158
Currently translated at 100.0% (5 of 5 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered_security/it/
…elds The fields to secure are defined on the sale.order.line model not on sale.order
Currently translated at 100.0% (8 of 8 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered_security/it/
chienandalu
reviewed
Nov 24, 2025
Andrii9090
force-pushed
the
18.0-mig-sale_margin_delivered_security
branch
from
f62bca2 to
6f0896b
Compare
Gelojr
approved these changes
Nov 27, 2025
Gelojr
left a comment
Gelojr
left a comment
There was a problem hiding this comment.
Congratulations for the work on this module @Andrii9090 , the PR is approved.
The following functional tests were executed:
- Test 1: A user with cost-view permissions successfully viewed the delivered-margin fields on a sales order line after delivery; all values were correctly computed and displayed.
- Test 2: A user without cost permissions could not see any cost or margin fields, including both the delivered-margin fields added by the module and the standard Odoo cost and margin fields; all of them were correctly hidden.
- Test 3: A user without cost permissions could not access the delivered-margin fields even in developer mode; the fields were not available in the view definition.
- Test 4: Delivered-margin values were correctly computed after a partial delivery and were only visible to users with cost-view permissions; users without permissions did not see any margin-related fields.
- Test 5: After removing cost-view permissions, the user no longer saw any delivered-margin fields on existing sales order lines, confirming that visibility reacts immediately to permission changes.
- Test 6: A user with cost-view permissions could see the product cost on the product form and the delivered-margin fields on sales order lines, all correctly shown as read-only.
- Test 7: Editing the standard cost on the sales order line after delivery may cause inconsistencies.
A user with cost-edit permissions can correctly modify the product cost on the product form, and new sales orders will use that updated value. However, this user can also manually edit the standard Odoo cost field on the sales order line itself. If a delivery has already been completed, changing this cost afterwards creates an inconsistency because the delivered-margin values were calculated using the previous cost. As an improvement, it would be helpful for Odoo to automatically log a message in the chatter whenever the standard cost on the sales order line is manually modified, so that any post-delivery cost changes remain traceable.
Member
|
/ocabot migration sale_margin_delivered_security |
rafaelbn
approved these changes
Nov 27, 2025
Member
rafaelbn
left a comment
rafaelbn
left a comment
There was a problem hiding this comment.
Functional review 👍🏼
/ocabot merge patch
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 077474e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward migration to v18
https://www.loom.com/share/cd61599fbe834ce8ae79431960dcb935
@moduon MT-11820