Update alg_cache to take verbose argument for compatibility with new OrdinaryDiffEqCore.__init#178
Update alg_cache to take verbose argument for compatibility with new OrdinaryDiffEqCore.__init#178jClugstor wants to merge 21 commits intoNumericalMathematics:mainfrom
alg_cache to take verbose argument for compatibility with new OrdinaryDiffEqCore.__init#178Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Pull Request Test Coverage Report for Build 21682043306Details
💛 - Coveralls |
|
Thanks, @jClugstor. Would you mind fixing the formatting issue and ideally look at the failing Downgrade test? Probably some compat bounds need to be bumped. Otherwise this LGTM. |
|
Thanks! Regarding the formatting: I guess you used JuliaFormatter.jl v2? Could you please use v1.0.60 because this is the version we currently use in CI. |
|
I believe that the SciMLBase lower compat bound just needed to be bumped to match the lower compat bound in OrdinaryDiffEq. I did that and then formatted so hopefully it's all good now. |
|
Oh yes I'll reformat. |
|
Looks like there are some formatting changes that survived. Could you please revert every formatting change not related to the |
|
The formatting and Downgrade should be fixed now. CI is currently failing because of some issues with OrdinaryDiffEq.jl introduced lately. Once this is fixed, this LGTM. Thanks again, @jClugstor. |
An upcoming PR (SciML/OrdinaryDiffEq.jl#2895) will change the number of arguments that
alg_cacheexpects inOrdinaryDiffEqCore.__init. This PR isn't needed yet, but will be needed in order to compatible with OrdinaryDiffEqCore when that PR merges.Closes #185.