Remove d_prototype & create type tests for p_prototype#104
Conversation
|
Does the version change to v0.2.0? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 6 6
Lines 1415 1414 -1
==========================================
- Hits 1388 1387 -1
Misses 27 27 ☔ View full report in Codecov by Sentry. |
Yes - this is a breaking change, so we have to increment the leading non-zero digit of the version number. We should also add something like to NEWS.md |
ranocha
left a comment
There was a problem hiding this comment.
Thanks! Could you please increment the version number and describe the changes in NEWS.md?
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
|
This should now be ready to merge. |
|
Thanks! I would like to merge #105 first, release a new version of PositiveIntegrators.jl, and merge this PR afterwards |
d_prototype, see the discussion in Used_prototypewhen solvingPDSProblems #99. In the algorithm caches we simply useD=similar(u)etc. APDSFunctionstill has a fieldd_protoypewhich is initialized asd_protoype=similar(u0), but users cannot change this or passd_protoypeas a keyword to aPDSProblem.Ps in the algorithm caches have the same type as a givenp_prototype(only for in-place)