Skip to content

Update dependency ModularPipelines.Git to v3 - abandoned #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nice3point wants to merge 1 commit into from
+1 −1
Closed

Update dependency ModularPipelines.Git to v3 - abandoned #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Build.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<PackageReference Include="Sourcy.DotNet" Version="0.7.9"/>
<PackageReference Include="Shouldly" Version="4.3.0"/>
<PackageReference Include="ModularPipelines" Version="2.48.30"/>
<PackageReference Include="ModularPipelines.Git" Version="2.48.30"/>
<PackageReference Include="ModularPipelines.Git" Version="3.0.1"/>
Copy link

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates ModularPipelines.Git to v3.0.1, which is a major version with significant breaking changes. However, the core ModularPipelines package and other ModularPipelines packages (GitHub, DotNet) remain at v2.48.30.

According to the v3 release notes, this creates a version mismatch problem. The existing code uses v2 API patterns that are incompatible with v3:

  1. The code uses IPipelineContext (v2) instead of IModuleContext (v3)
  2. PipelineHostBuilder.Create() in Program.cs should be Pipeline.CreateBuilder(args) (v3)
  3. GetModule<T>() is called on modules instead of on context (v3 requires context.GetModule<T>())

Either all ModularPipelines packages should be updated to v3 together, or this update should be held back until the codebase can be migrated to the v3 API. Mixing v2 and v3 packages is likely to cause runtime compatibility issues.

Suggested change
<PackageReference Include="ModularPipelines.Git" Version="3.0.1"/>
<PackageReference Include="ModularPipelines.Git" Version="2.48.30"/>

Copilot uses AI. Check for mistakes.
<PackageReference Include="ModularPipelines.GitHub" Version="2.48.30"/>
<PackageReference Include="ModularPipelines.DotNet" Version="2.48.30"/>
<PackageReference Include="JetBrains.Annotations" Version="2025.2.4"/>
Expand Down
Loading