Dev

[mzcydev]

No description provided.

[Copilot]

Pull Request Overview

This PR implements a comprehensive "dev" environment with significant additions to the plugin framework, including new UI systems, database management, performance monitoring, and plugin integrations. The changes primarily focus on adding modern development tooling and architectural patterns to the existing NextForge framework.

Key changes include:

• Complete UI system with inventory management, layouts, and support components
• Performance monitoring and profiling infrastructure
• Database abstraction layer with support for multiple database types (SQL, MongoDB, Redis)
• Plugin bridge system for third-party integrations (Vault, PlaceholderAPI, LuckPerms)

Reviewed Changes

Copilot reviewed 92 out of 94 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
plugin.yml	Added Vault as soft dependency
ChatPagination.java	Removed legacy chat pagination utility
NextForgePlugin.java	Integrated new UI and database managers, performance monitoring
Multiple UI files	Complete UI framework with components, layouts, inventory management
Multiple database files	Database abstraction layer with repository patterns
Multiple performance files	Performance monitoring and profiling system
Multiple bridge files	Plugin integration framework

Comments suppressed due to low confidence (2)

src/main/java/gg/nextforge/performance/TickListener.java:1

• The package declaration 'gg.nextforge.performance.listener' does not match the file location. The file is in 'src/main/java/gg/nextforge/performance/' but the package suggests it should be in a 'listener' subdirectory.

package gg.nextforge.performance.listener;

src/main/java/gg/nextforge/bridge/impl/LuckPermsBridge.java:1

• The package declaration should be 'gg.nextforge.bridge.impl' to match the file location, not 'gg.nextforge.bridge'.

package gg.nextforge.bridge;

[Copilot]

Calling unregister(this) on the handler list will not work as expected because 'this' refers to the anonymous listener, not a registered handler. This could cause memory leaks as the event handler may not be properly unregistered.

Suggested change

	InventoryCloseEvent.getHandlerList().unregister(this);
	}
	}
	}, plugin);
	InventoryCloseEvent.getHandlerList().unregister(listener);
	}
	}
	};
	Bukkit.getPluginManager().registerEvents(listener, plugin);

[Copilot]

[nitpick] The onSwitch method is empty and only contains a comment. Consider either implementing the functionality or removing the empty method to reduce code clutter.

Suggested change

	@org.bukkit.event.EventHandler
	public void onSwitch(PlayerItemHeldEvent event) {
	// Optional: clear hotbar on slot switch if desired
	}

[Copilot]

The parentheses around 'connectionString' are unnecessary and should be removed for cleaner code.

Suggested change

	String uri = (connectionString);
	String uri = connectionString;

[Copilot]

The import path 'gg.nextforge.performance.listener.TickListener' is incorrect. Based on the file structure, it should be 'gg.nextforge.performance.TickListener' since TickListener.java is directly in the performance package.

Suggested change

	import gg.nextforge.performance.listener.TickListener;
	import gg.nextforge.performance.TickListener;

[Copilot]

The conversion factor should be a named constant instead of a magic number. Consider defining 'private static final long MILLIS_PER_TICK = 50L;' for better maintainability.

Suggested change

	return ticks * 50L; // 20 ticks = 1 second
	return ticks * MILLIS_PER_TICK; // 20 ticks = 1 second