Limit bitmap dimensions to-supplied dimensions, the bitmap options do not exceed 2048x2048 to prevent bitmap overflow on Android 2048x2048, which prevents overflow/crashes on Android API 22.Update imagepicker.android.ts#343
Open
zeebie-new wants to merge 1 commit intoNativeScript:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On Android API 22, setting large values for
widthorheightinImageAssetOptionscauses the app to crash with "bitmap size exceeds 32 bits" (see #6289).What is the new behavior?
This change caps the bitmap dimensions to
2048x2048inimagepicker.android.tsto prevent bitmap overflow and crashes on API 22. The cap is applied regardless of user-supplied dimensions.Fixes/Implements/Closes #6289.