Extract single element of array before declaring amplitude of adjoint source#3129
Merged
oskooi merged 1 commit intoNanoComp:masterfrom Dec 24, 2025
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3129 +/- ##
==========================================
+ Coverage 73.81% 73.90% +0.09%
==========================================
Files 18 18
Lines 5423 5454 +31
==========================================
+ Hits 4003 4031 +28
- Misses 1420 1423 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A unit test for the adjoint solver (
test_two_objfuncoftest_adjoint_solver.py) recently started failing during CI for Python 3.11 due to the following line:meep/python/source.py
Line 127 in e407a5a
The error is triggered when
amplitudeis passed to theSourceconstructor as a Numpy array with a single element. Python'scomplexfunction supports 0-dimensional Numpy arrays. The fix simply involves extracting the element of the array before applying thecomplexfunction.(It is not clear why this error was triggered recently and only for Python 3.11.)