Skip to content

Compute the flux in the far fields using a Trapezoidal rule rather than a Riemann sum#3126

Merged
stevengj merged 1 commit intoNanoComp:masterfrom
oskooi:flux_trapezoidal_rule
Dec 12, 2025
Merged

Compute the flux in the far fields using a Trapezoidal rule rather than a Riemann sum#3126
stevengj merged 1 commit intoNanoComp:masterfrom
oskooi:flux_trapezoidal_rule

Conversation

@oskooi
Copy link
Collaborator

@oskooi oskooi commented Dec 12, 2025

Modifies the calculation of the total flux of the far fields using the Trapezoial Rule (via numpy.trapezoid) rather than the existing finite summation (numpy.sum) for the tutorial examples in Near to Far Field Spectra. This change is intended to simplify the calculation and slightly improve its accuracy.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.89%. Comparing base (f29a8c7) to head (04d6777).
⚠️ Report is 96 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
+ Coverage   73.81%   73.89%   +0.08%     
==========================================
  Files          18       18              
  Lines        5423     5452      +29     
==========================================
+ Hits         4003     4029      +26     
- Misses       1420     1423       +3     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj stevengj changed the title Compute the flux in the far fields using a Trapezoidal rule rather than a finite sum Compute the flux in the far fields using a Trapezoidal rule rather than a Riemann sum Dec 12, 2025
@stevengj stevengj merged commit e407a5a into NanoComp:master Dec 12, 2025
5 checks passed
@oskooi oskooi deleted the flux_trapezoidal_rule branch December 12, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants