Skip to content

Update docstrings to state usage of border padding#3123

Merged
stevengj merged 3 commits intoNanoComp:masterfrom
lxvm:patch-1
Dec 12, 2025
Merged

Update docstrings to state usage of border padding#3123
stevengj merged 3 commits intoNanoComp:masterfrom
lxvm:patch-1

Conversation

@lxvm
Copy link
Contributor

@lxvm lxvm commented Dec 1, 2025

The filter routines stated that they used zero padding of the design variables in convolution filters where they actually used border padding. I updated docstrings to reflect this.

@stevengj
Copy link
Collaborator

stevengj commented Dec 1, 2025

It would be good to expand the docs to precisely define "border padding".

@lxvm
Copy link
Contributor Author

lxvm commented Dec 9, 2025

Thanks, I updated the docstrings to explain the implementation and purpose of border padding

changing this was a typo
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.89%. Comparing base (f29a8c7) to head (da9410e).
⚠️ Report is 96 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
+ Coverage   73.81%   73.89%   +0.08%     
==========================================
  Files          18       18              
  Lines        5423     5452      +29     
==========================================
+ Hits         4003     4029      +26     
- Misses       1420     1423       +3     
Files with missing lines Coverage Δ
python/adjoint/filters.py 70.37% <ø> (+0.60%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj stevengj merged commit 2d40b85 into NanoComp:master Dec 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants