Skip to content

Simplify tutorial script for computing the radiation pattern of an antenna above a ground plane in 1D#3119

Merged
oskooi merged 2 commits intoNanoComp:masterfrom
oskooi:antenna_1d_tutorial_script_simplify
Nov 26, 2025
Merged

Simplify tutorial script for computing the radiation pattern of an antenna above a ground plane in 1D#3119
oskooi merged 2 commits intoNanoComp:masterfrom
oskooi:antenna_1d_tutorial_script_simplify

Conversation

@oskooi
Copy link
Collaborator

@oskooi oskooi commented Nov 26, 2025

This PR simplifies the example script for Tutorial/Antenna above a Perfect Electric Conductor Ground Plane. Previously, this script involved a calculation of the radiation pattern in free space which has been removed as it is not necessary.

These changes are in preparation for a unit test for boundary conditions in 1D that will be added shortly which will be based on this calculation.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.84%. Comparing base (f29a8c7) to head (edca75c).
⚠️ Report is 92 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
+ Coverage   73.81%   73.84%   +0.02%     
==========================================
  Files          18       18              
  Lines        5423     5452      +29     
==========================================
+ Hits         4003     4026      +23     
- Misses       1420     1426       +6     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oskooi oskooi merged commit a552977 into NanoComp:master Nov 26, 2025
5 checks passed
@oskooi oskooi deleted the antenna_1d_tutorial_script_simplify branch November 26, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants