Skip to content

Clean MSan warnings#8

Open
jianguan210 wants to merge 1 commit intoNanoComp:masterfrom
jianguan210:clean_msan_error_warning
Open

Clean MSan warnings#8
jianguan210 wants to merge 1 commit intoNanoComp:masterfrom
jianguan210:clean_msan_error_warning

Conversation

@jianguan210
Copy link

  1. Changed to calloc to create and initialize arrays.
  2. Initialized info before using.

1. Changed to `calloc` to create and initialize arrays.
2. Initialized `info` before using.
@stevengj
Copy link
Collaborator

See my comment here: NanoComp/mpb#131 (comment)

@jianguan210
Copy link
Author

Hi Prof. Johnson, I switched calloc back to malloc. The tests with MSan gave a few warnings of use-of-uninitialized-value. I tried to explicitly initialize them one by one but could solve all, because one of the warnings complains use-of-uninitialized-value at c *= c(the line 166 in "harminv.c" file) when the case "aniso_disp" is ran. I cannot figure out the reason. Since this is just a warning, I will leave it here first, and circle back later. Please let me know if you have any findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants