Skip to content

Conversation

@aaronfriedman6
Copy link
Contributor

The cursor description contains the column names, which are necessary for loading the data correctly in the Data Viz project.

Copy link
Contributor

@fatimarahman fatimarahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you elaborate more on how the cursor description will be used? Still unclear on how you'll use it in Data Viz

@aaronfriedman6
Copy link
Contributor Author

aaronfriedman6 commented Mar 25, 2025

Looks good! Can you elaborate more on how the cursor description will be used? Still unclear on how you'll use it in Data Viz

Each visualized metrics is stored as a table with two required columns (the date and the value). Each of the remaining columns corresponds to a filter. The viz layer has no idea what metrics have what filters -- this is by design so that STRAD can upload files with whatever filters they like without having to ask us to make manual changes to the tables first -- so it's querying for all the columns in the table every time. Hence, in order to display the columns correctly, the viz layer has to essentially use the name of the column as the filter id. Separately, files are provided that map from these filter ids to various pieces of text.

Of course it's possible to query separately for the names of the columns but it seemed unnecessary to me when the cursor description already provides that information.

@aaronfriedman6 aaronfriedman6 merged commit 8e4e968 into main Mar 25, 2025
2 checks passed
@aaronfriedman6 aaronfriedman6 deleted the postgres-desc branch March 25, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants