fix: resolve webhook caBundle deadlock during helm upgrade#164
Merged
lockwobr merged 1 commit intorelease/v0.12.xfrom Feb 10, 2026
Merged
fix: resolve webhook caBundle deadlock during helm upgrade#164lockwobr merged 1 commit intorelease/v0.12.xfrom
lockwobr merged 1 commit intorelease/v0.12.xfrom
Conversation
During helm upgrade, the webhook configurations' caBundle field was reset to empty, causing new pods to fail readiness checks while the old leader pod never detected the change (only watched the cert Secret, with a 24h requeue). This created a deadlock where no pod could fix the caBundle. - Watch ValidatingWebhookConfiguration and MutatingWebhookConfiguration so the leader detects caBundle changes immediately - Use bytes.Equal for caBundle comparison instead of len==0 so stale values are corrected, not just empty ones - Remove caBundle from Helm webhook templates so upgrades stop resetting operator-managed values
lockwobr
requested review from
ayuskauskas,
mskalka and
riceriley59
as code owners
riceriley59
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During helm upgrade, the webhook configurations' caBundle field was reset to empty, causing new pods to fail readiness checks while the old leader pod never detected the change (only watched the cert Secret, with a 24h requeue). This created a deadlock where no pod could fix the caBundle.