chore: update Pangea User-Agent repo URL (#1595)#1610
Conversation
Greptile OverviewGreptile SummaryUpdated the repository URL in the Pangea integration User-Agent header from This change aligns with the repository migration (see commit 632678d) and ensures the HTTP headers sent to Pangea AI Guard API reflect the current repository location. The change is purely cosmetic and has no impact on functionality. Note: One old URL reference remains in
|
| Filename | Overview |
|---|---|
| nemoguardrails/library/pangea/actions.py | Updated User-Agent header to use new repository URL |
Sequence Diagram
sequenceDiagram
participant Client as NeMo Guardrails
participant HTTP as httpx.AsyncClient
participant Pangea as Pangea AI Guard API
Note over Client,Pangea: Updated User-Agent Header
Client->>HTTP: Create request with headers
Note right of HTTP: User-Agent: NeMo Guardrails<br/>(https://github.com/NVIDIA-NeMo/Guardrails)
HTTP->>Pangea: POST /v1/text/guard
Pangea-->>HTTP: Response
HTTP-->>Client: Return result
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Update repository URL in Pangea integration User-Agent header.
82c9bd6 to
bfa9606
Compare
|
This PR only updates the Pangea integration User-Agent string to point to the new repository URL: There are no code logic changes in this PR; only the User-Agent header string in All tests pass on newer Python versions:
The only failing job is:
From the logs, the 3.10 job fails during I added a Signed-off-by line to comply with the contribution guidelines, but that only touched the |
|
Are we sure Pangea / Crowdstrike does not do any validation on the User-Agent field? Maybe @kenany who opened a MR for the new Crowdstrike AIDR can help us (Pangea was acquired by Crowstrike and this integration will be deprecated soon if I understand correctly)? |
Need to make sure server-side updates are deployed before this change is made
No such validation is done. This change is good to go from that angle. |
There was a problem hiding this comment.
Looks good, as no validation is made by Pangea API on the user-agent.
Thanks @ichbinlucaskim and @kenany !
Update repository URL in Pangea integration User-Agent header.
Description
This PR updates the remaining reference to the old repository URL in the Pangea integration User-Agent header.
Only the
User-Agentheader string innemoguardrails/library/pangea/actions.pyis changed to point tohttps://github.com/NVIDIA-NeMo/Guardrails.Related Issue(s)
Fixes #1595.
Checklist