fix: Fix onnx export #590
Open
fix: Fix onnx export #590
+267
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
requested review from
a team,
athitten,
meatybobby,
oyilmaz-nvidia and
pthombre
as code owners
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
… nemo Signed-off-by: Charlie Truong <chtruong@nvidia.com>
…rmat not nemo" This reverts commit 445bf82. Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fix onnx export
This transformers commit broke onnx export for us.
huggingface/transformers#37866
Unsure if these changes are legit. Got help from Claude Code with resolving after bisecting transformers. More of the onnx functional tests pass.
Also, had to work around some issues with quantization. Some failure in the onnx export with fake tensors.