Upgrade to Django 1.11 #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alongwith Django 1.11, python-social-auth and Pillow have been upgraded. Fixes #108.
Member
|
@nkprince007 is a newer version of coala fix the builds? |
ghoshbishakh
requested changes
Jun 1, 2017
| 'social_core.backends.google.GoogleOAuth2', | ||
| 'social_core.backends.google.GoogleOAuth', | ||
| 'social_core.backends.twitter.TwitterOAuth', | ||
| 'social_core.backends.yahoo.YahooOpenId', |
Member
There was a problem hiding this comment.
why so many of these? Please remove the unnecessary ones. We only need google and facebook for now.
Contributor
Author
There was a problem hiding this comment.
Does having extra of these affect performance?
Member
There was a problem hiding this comment.
@ankan17 no but we must have clarity on why we need these. This might confuse us in future. Please remove the Twitter etc.
| django-ckeditor==5.1.1 | ||
| django-email-extras==0.3.3 | ||
| django-forms-builder==0.13.0 | ||
| future==0.15.0 |
Member
There was a problem hiding this comment.
why are these dependencies required?
| pyparsing==2.2.0 | ||
| python-gnupg==0.4.0 | ||
| python3-openid==3.0.10 | ||
| pytz==2017.2 |
| django-forms-builder==0.13.0 | ||
| social-auth-app-django==1.2.0 | ||
| social-auth-core==1.3.0 | ||
| sphinx-me==0.3 |
| social-auth-app-django==1.2.0 | ||
| social-auth-core==1.3.0 | ||
| sphinx-me==0.3 | ||
| Unidecode==0.4.20 |
| oauthlib==1.1.2 | ||
| Pillow==3.3.1 | ||
| olefile==0.44 | ||
| packaging==16.8 |
Member
|
It should.
|
Member
|
@ankan17 hey so can you update the version of coala too? |
Member
|
@ankan17 please lock the coala and coala-bears packages to 0.10.
|
Contributor
Author
|
I have never used coala before.. I don't know how it is used! |
Member
|
@ankan17 no need to change anything. Just put the latest version of coala in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alongwith Django 1.11, python-social-auth and Pillow have been upgraded.
Fixes #108.