Skip to content

Conversation

@davidhassell
Copy link
Collaborator

Fixes #894 and #895

@davidhassell davidhassell added this to the NEXTVERSION milestone Jan 8, 2026
@davidhassell davidhassell added enhancement New feature or request dataset read Relating to reading datasets dataset write Relating to writing datasets zarr labels Jan 8, 2026
@davidhassell
Copy link
Collaborator Author

Not a very large PR, this one! I don't know what to do about the recipe files linting thing ...

@davidhassell davidhassell linked an issue Jan 8, 2026 that may be closed by this pull request
@sadielbartholomew
Copy link
Member

I don't know what to do about the recipe files linting thing ...

As for reverting the recipes linter/isort auto-changes as discussed in-person, the git command I mentioned that is simplest would be git checkout <commit hash> -- <dir> where you use the hash/reference of the commit where the recipes dir was in its original state, which I recommend as one just before the PR, and the docs/source/recipes path (apparently there is a git restore approach which is more modern but I don't have experience with that so I'll stick with what I've used and know to be good).

@sadielbartholomew
Copy link
Member

I'll start reviewing now ignoring the linting changes to the recipes...

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, with tests all passing and relevant packaging, docs and tests updates for the new Zarr read and write funcionality - though ideally drop the recipes linting auto-changes as discussed in person (see my comment above for recommended command to revert).

@davidhassell
Copy link
Collaborator Author

Thanks for the git command. I did git checkout 9328936f04628183b8f6eda1a06006c50e5a54e9 -- docs/source/recipes/ which fixed 7 of the dodgy changes. I need to have a look at the others.

@davidhassell davidhassell merged commit 7305962 into NCAS-CMS:main Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dataset read Relating to reading datasets dataset write Relating to writing datasets enhancement New feature or request zarr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write Zarr datasets Read grouped Zarr datasets

2 participants