-
Notifications
You must be signed in to change notification settings - Fork 38
Combine Triggered and Triggerable outputs, define MC trigger bits #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @michaelmackenzie,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 69fb87d: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 69fb87d.
N.B. These results were obtained from a build of this Pull Request at 69fb87d after being merged into the base branch at 408fdd7. For more information, please check the job page here. |
|
📝 The HEAD of |
brownd1978
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an important upgrade that will require changes to all analysis workflows.
Beyond the scope of this PR, I notice there's no KL triggerable path. That isn't needed for current Extracted digitization, but it will be needed for FieldOff digitization, including run1b scenario.
|
@FNALbuild run build test |
|
⌛ The following tests have been triggered for be154d1: build (Build queue - API unavailable) |
|
☀️ The build tests passed at be154d1.
N.B. These results were obtained from a build of this Pull Request at be154d1 after being merged into the base branch at 192f431. For more information, please check the job page here. |
This defines MC trigger bits with bits below 100 (where the real triggers begin) but beyond what was likely used previously. Users will now have both triggered events and "triggerable" events (in the case of MC processing) in a single dataset, where checking the trigger results for path names or bits will be necessary when handling MC from now on instead of relying on the dataset to select the OR of the triggers of interest.
This should reduce the output dataset tape usage by about a factor of 2 (due to the high overlap between triggerable and triggered), while also making trigger efficiency checks easier on users.