Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSA_PrivateToPublic: The serializer only wrote priv, but the generator/modules expect p, g, and priv. The OpenSSL backend also only set priv and never set p/g, so key generation effectively fails. Fix: in DSA_PrivateToPublic::Serialize, emit g, p, and priv in that order. In modules/openssl/module.cpp, parse op.p/op.g/op.priv into BIGNUMs and compute pub = g^priv mod p (e.g., via BN_mod_exp), returning the decimal string so the OpenSSL backend can produce a public key.
KDF_SRTP / KDF_SRTCP: The serializers omitted index, but the generator fills it and the wolfCrypt implementations consume it. Fix: in the corresponding Serialize methods, write out index along with key/salt/kdr/key1-3Size.