Open
Conversation
ajude2s
reviewed
Dec 11, 2025
ajude2s
reviewed
Dec 11, 2025
ajude2s
reviewed
Dec 12, 2025
ajude2s
reviewed
Dec 12, 2025
ajude2s
reviewed
Dec 12, 2025
ajude2s
reviewed
Dec 12, 2025
ajude2s
reviewed
Dec 12, 2025
ajude2s
reviewed
Dec 12, 2025
Comment on lines
75
to
76
| if max_allowed <= 0: | ||
| return pool.head(0).copy() |
Collaborator
There was a problem hiding this comment.
Redundant. There is a check above if pool.empty or target <= 0.
max_allowed will be less than or equal to 0 only if max_oversampling_ratio is less than 0.
Which would never be the case, right?
ajude2s
requested changes
Dec 12, 2025
Collaborator
ajude2s
left a comment
There was a problem hiding this comment.
Awesome work, Abbas. 👍
I have added minor changes and some suggestions.
Also, should we not add the original sampler (the fixed distribution which yields "best" performance) as well?
ajude2s
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a configurable uniform split sampler for JSONL datasets, along with its configuration and tests. 🎯
Adds
UniformSplitSampler, which:scorefield per example and normalizes these scores._build_splitssplit_label_poolsto partition each label’s pool into train/val.max_oversampling_ratiocap so rare labels are upsampled but not duplicated arbitrarily.In short: this sampler helps you build balanced, reproducible, and well-logged train/val splits from JSONL.