Fix Pydantic validation error: make LocalExecutionSettings.logging_dir optional#242
Closed
Fix Pydantic validation error: make LocalExecutionSettings.logging_dir optional#242
Conversation
Copilot
AI
changed the title
[WIP] Fix validation error for LocalExecutionSettings due to missing logging_dir
Fix Pydantic validation error: make LocalExecutionSettings.logging_dir optional
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalExecutionSettingsinannotation_pipeline.pydefineslogging_dir: Optional[str]without a default value, causing Pydantic to require it. Users encounter validation errors when omitting it from configs.Changes
annotation_pipeline.py: Add default values toLocalExecutionSettingsfields to matchembedding_pipeline.py:test_local_execution_settings.py: Add test coverage for instantiation with and withoutlogging_dirThe existing
set_logging_dirvalidator continues to auto-populatelogging_diras{output_dir}/logswhenNone.Original prompt
Created from VS Code via the GitHub Pull Request extension.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.