Skip to content

Conversation

@stephantul
Copy link
Contributor

The typing on the main query methods in vicinity was incorrect: it used the type used in the internal backends, i.e., a list of tuple of index, distance arrays. But Vicinity itself returns a list[list[str, float]] for both the normal query and query_threshold functions.

@stephantul stephantul requested a review from Pringled July 14, 2025 13:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
vicinity/vicinity.py 95.42% <100.00%> (-2.25%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@stephantul stephantul merged commit a33a312 into main Jul 15, 2025
5 checks passed
@stephantul stephantul deleted the fix-typing branch July 15, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants