feat: add environment prefix to email subjects

[SylvainChevalier]

Add [dev] or [play] prefix to email subjects when running in dev or play environments to help distinguish them from production emails.

Changes

• Modified send_email_with_template() to add prefix based on METACULUS_ENV
• Created get_email_subject_with_env_prefix() helper for direct EmailMessage usage
• Applied helper to all EmailMessage instances in utils/tasks.py and misc/views.py

Fixes #3899

Generated with Claude Code

[SylvainChevalier]

Feel free to reject if this adds too much complexity or is too hard to maintain or etc.

[hlbmtc]

@claude I don't like the solution at all. Implement it globally in one place only -- send_email_async

[claude]

Claude finished @hlbmtc's task in 5m 3s —— View job

---

Refactoring Complete ✓

I've successfully refactored the implementation to centralize all email prefix logic in misc/tasks.py as requested.

Changes Made

Single source of truth in misc/tasks.py:

• Created add_env_prefix_to_subject() function (lines 12-17) - the single place where prefix logic lives
• Modified send_email_async() to use this function (line 39)

Cleanup across codebase:

• Removed duplicate prefix logic from utils/email.py
• Removed get_email_subject_with_env_prefix() helper from utils/tasks.py
• Updated all 6 EmailMessage instances in utils/tasks.py to use the centralized function
• Updated both EmailMessage instances in misc/views.py to use the centralized function

Result: All email prefix logic now lives in one place (misc/tasks.py), making it easy to maintain and modify.

Tests: Verified existing tests only mock send_email_async and don't reference the old helper, so no test updates needed.

---

Branch: claude/issue-3899-20251210-1048

[SylvainChevalier]

@claude the integration tests failed, fix the issues.

[claude]

Claude finished @SylvainChevalier's task in 1m 32s —— View job

---

Test Failures Fixed ✓

Todo List:

• Check CI status to identify failing tests
• Analyze the test failures
• Read relevant files to find circular import issue
• Identify root cause
• Fix the circular import
• Commit and push changes

Summary:

Fixed the circular import error that was causing both unit tests and integration tests to fail.

Problem:

• Error: ImportError: cannot import name 'User' from partially initialized module 'users.models' (most likely due to a circular import)
• In misc/tasks.py line 7, User was imported at the module level: from users.models import User
• This created a circular import during Django initialization

Solution:

• Moved the User import from module level to inside the filter_staff_emails function (where it's actually used)
• This defers the import until the function is called, avoiding the circular dependency during module initialization

Changes:

• misc/tasks.py: Removed module-level import and added import inside filter_staff_emails function

The fix has been committed and pushed. The CI tests should now pass.

---

Branch: claude/issue-3899-20251210-1048 |

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/issue-3899-20251210-1048

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}