Merged
Conversation
e72b34d to
eaa6592
Compare
| amountOutMinimum, | ||
| currencyIn: USDC_ADDRESS, | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
Bug: Swap Parameters: Order Matters
Parameter order mismatch in SWAP_EXACT_IN action. The SWAP_EXACT_IN_STRUCT expects parameters in order: currencyIn, path, amountIn, amountOutMinimum, but the object passed has path before currencyIn. This will cause incorrect encoding and transaction failure. Reorder the object properties to match the struct definition.
OGPoyraz
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds a new batch USDC→ETH swap using wallet_sendCalls and refactors shared swap logic into swapUtils; updates Swap Comparison to use the shared utilities and wires the new component into the app.
batchUsdcSwapcomponent (src/components/transactions/batchUsdcSwap.js):wallet_sendCalls(EIP-5792).src/components/transactions/swapUtils.js): constants (addresses, defaults), parsing helpers, V4 action builders, and encoding helpers (approve/permit2).swapComparisonto import fromswapUtils, removing duplicated constants/helpers.batchUsdcSwapincomponents/transactions/index.jsand render it insrc/index.js.Written by Cursor Bugbot for commit eaa6592. This will update automatically on new commits. Configure here.