#723: Add soil thickness processor #758
Conversation
|
ATP but function requires additional testing with a simple "real life" cube with a known expected output. These tests should include at least 2 cubes (one with ice_class and one without). Unit tests should also be added to ensure maintained functionality once the function is able to produce a reliable expected result. |
|
NOTE: A minor change to the error message under the _z_axis() function has been made to provide better clarity on what exactly is causing the error to be raised (e.g. is the script identifying too many Z axis or none at all) rather than just stating that there must be 1. |
|
NOTE: a warning is logged if the source soil cube is identified as not having a mask. This is not written as a critical failure or exception as I am currently assuming that not every cube will have a land/sea mask. A debug flag seemed too minor, since incorrectly failing to apply such a mask could affect data integrity or produce incorrect results. It should be confirmed at a later date whether this assumption is correct and logging should be adapted accordingly prior to merging. |
|
ATP |
|
ATP |
mo-laurenboon
changed the title
mo-laurenboon
changed the title
mo-laurenboon
requested review from
matthew-mizielinski,
mo-gill and
mo-jareddrayton
Closes issue #723.
A function is added to calculate the soil thickness as required by variable land.slthick.ti.sl-hxy-lnd.fx.GLB (Efx.slthick). This function can also apply any existing land/sea masks where applicable as well as accounting for ice root depth.