Data parsing, BlockfrostProvider arg check, Node.js error fix#721
Open
PiotrNap wants to merge 5 commits intoMeshJS:mainfrom
Open
Data parsing, BlockfrostProvider arg check, Node.js error fix#721PiotrNap wants to merge 5 commits intoMeshJS:mainfrom
PiotrNap wants to merge 5 commits intoMeshJS:mainfrom
Conversation
- remove useless utf8 string validation - fix returned type of `toBytes` func - clean up code by reuising `isHexString`
- this prevents 'XMLHttpRequest is not defined' error when the code is executed inside node.js environment
- check for valid 1st argument - replace wrong blockfrost urls in playground example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Parser
toBytesfuncisHexString& write test cover for every functionBlockfrostProvider
HTTP Error Parser
Summary
Affect components
@meshsdk/common@meshsdk/contract@meshsdk/core@meshsdk/core-csl@meshsdk/core-cst@meshsdk/hydra@meshsdk/provider@meshsdk/react@meshsdk/svelte@meshsdk/transaction@meshsdk/walletType of Change
Related Issues
Checklist
npm run test)npm run build)Additional Information