feat: create CustomPropertiesStream class#268
feat: create CustomPropertiesStream class#268MindaugasN wants to merge 16 commits intoMeltanoLabs:mainfrom
Conversation
feat: create CustomPropertiesStream class
|
Seeing a 404 in the tests: Perhaps we should think of a way of skipping/deselecting this stream for non-org namespaces? |
Is there already an example with that? And how to tell if a namespace is org / non-org? |
@MindaugasN I think moving it here tap-github/tap_github/streams.py Lines 118 to 121 in f41b66d would be enough |
feat: create CustomPropertiesStream class
|
I moved, but first of all, I am not sure, if I did that correctly. |
Can you say more about this? What do you mean it's not working anymore?
Not really. The stream class can stay in
I think you're missing a newline at the end of |
feat: create CustomPropertiesStream class
feat: create CustomPropertiesStream class
Got it, that solved all my problems :) And with the test - I ran Black locally and formatted my code |
feat: create CustomPropertiesStream class
|
I think we're back at #268 (comment) 😅 |
Trying to pick up the torch from #268, since we also have a need for this stream. :) Added @MindaugasN to the commit for credit. Co-authored-by: MindaugasN <mindaugas@nizauskas.com>
create CustomPropertiesStream class that fetches data from https://docs.github.com/en/rest/repos/custom-properties?apiVersion=2022-11-28