Open
Conversation
Jonathan-Improving
left a comment
Jonathan-Improving
left a comment
There was a problem hiding this comment.
I see the test_mem0_storage.py uses mocked service objects, were you able to integration test this at all?
Owner
Author
|
the integration tests, such as there are, work -mostly by using recordings of LLM interactions. However testing it in the use case I'm working on - crewai with Mem0 and Valkey - works. |
MatthiasHowellYopp
force-pushed
the
mh/fix/valkey
branch
4 times, most recently
from
3fcda10 to
552bc23
Compare
MatthiasHowellYopp
force-pushed
the
mh/fix/valkey
branch
from
552bc23 to
43aa31f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with using mem0 as external memory with valkey/redis as vector store