feat: make ServerlessClient EventEmitter#95
Open
perrin4869 wants to merge 1 commit intoMatteoGioioso:masterfrom
Open
feat: make ServerlessClient EventEmitter#95perrin4869 wants to merge 1 commit intoMatteoGioioso:masterfrom
perrin4869 wants to merge 1 commit intoMatteoGioioso:masterfrom
Conversation
84e793d to
b27e440
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been running this patch locally for a while.
It is technically a breaking change, because
.onwould stop attaching events directly to the internal client...But I think this is an important change, because otherwise we don't have any way to be notified of when a client is initiated.
I think another problem with the old approach is that, if the
_clientgets refreshed at any point during the runtime, for example, by callingend, the events attached to it would disappear.The way this issue is solved with this PR would be:
With this method, if
endandconnectare called, the events will be reattached to the new client