Conversation
Signed-off-by: afreyermuth98 <anthofreyer@gmail.com>
Signed-off-by: afreyermuth98 <anthofreyer@gmail.com>
There was a problem hiding this comment.
That's a solid start. Thanks for volunteering :) I like that you made naming/namespacing configurable.
The cert-manager part seems to be missing, and our original cert-manager manifest appears to have been dropped. The hook cannot function without TLS enabled as far as I know. I'm not familiar with how folks deal with their PKI without cert-manager these days - so I don't know if it makes sense to support something else.
A nitpick: I'm not sure adding suffixes to resources names like -cluster-role or -role is idiomatic - even though it does happen in the wild - most resources are not named like that. After all, the resources do have a well defined type that transpires through kubectl get role/rolename for instance.
charts/node-specific-sizing/templates/mutatingadmissionwebhook.yaml
Outdated
Show resolved
Hide resolved
charts/node-specific-sizing/templates/tests/test-connection.yaml
Outdated
Show resolved
Hide resolved
|
Hey @eliebleton-manomano ! |
2 participants
PR about this issue :
#2 (comment)