-
Notifications
You must be signed in to change notification settings - Fork 5
Updated base images for pangeo and isce3 and updated isce3 #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
A couple of questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some package specific comments. Broadly I agree with Alex that it would be great to use the same modified Pangeo image.
| - s3fs=2025.9.0 | ||
| - scikit-learn=1.7.2 | ||
| - scipy=1.16.3 | ||
| - s3fs=0.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a substantial downgrade.
| - nodejs=25.2.1 | ||
| - numba=0.63.1 | ||
| - numpy=2.3.5 | ||
| - pandas=2.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an intentional downgrade?
| - cython=3.2.4 | ||
| - earthengine-api=1.7.12 | ||
| - fsspec=2026.1.0 | ||
| - gdal=3.11.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the gdal version in an env update makes me a little nervous.
|
|
I ran a script to pull the pangeo/pangeo-notebook images released in 2024-2026 then attempt to install the most recent isce3 version, every base image failed so we will need to continue with pangeo/base-notebook Note for future reference on this PR, I tried up to pangeo notebook image tag 2026.01.30 So I will continue with implementing the suggestions for isce3 image as is |
| # - git+https://github.com/MAAP-Project/stac_ipyleaflet.git@0.3.6 | ||
| - jupyter-sshd-proxy | ||
| - rio-tiler>=7.2.2 | ||
| - rio-tiler==8.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add rio-tiler to the next release of the veda image.
| TITILER_ENDPOINT: 'https://openveda.cloud/api/raster' | ||
| STAC_CATALOG_NAME: 'VEDA STAC' | ||
| STAC_CATALOG_URL: 'https://openveda.cloud/api/stac' | ||
| STAC_BROWSER_URL: 'https://openveda.cloud/' No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will still be in the env since they come with the VEDA image. Would it make more sense to override them with the MAAP equivalents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, once we have the MAAP equivalents we will override in our 2i2c infrastructure config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually do have MAAP equivalents, but we don't use them in any tutorials, and originally they were for stac_ipyleaflet support.
TITILER_STAC_ENDPOINT: 'https://titiler.maap-project.org/stac'
TITILER_ENDPOINT: 'https://titiler.maap-project.org/'
STAC_CATALOG_NAME: 'MAAP STAC'
STAC_CATALOG_URL: 'https://stac.maap-project.org/'
STAC_BROWSER_URL: 'https://stac-browser.maap-project.org'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That list is right but I think we can drop TITILER_STAC_ENDPOINT
isce3 and base images most up to date and tested
Made sure VS code extension still works