-
Notifications
You must be signed in to change notification settings - Fork 17
ci(testing): add verbose output when GitHub Actions debug logging is enabled #3788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughReplaces the package.json Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer (npm test)
participant NPM as npm
participant Runner as Node script\nscripts/run-tests.cjs
participant Stencil as stencil CLI
participant OS as Operating System
Dev->>NPM: run `npm test`
NPM->>Runner: invoke `node scripts/run-tests.cjs` (env passed)
Runner->>Runner: read env (ACTIONS_STEP_DEBUG, RUNNER_DEBUG, DEBUG)\nbuild args ['test','--spec','--e2e'] + CLI args\nset SASS_PATH=node_modules
Runner->>Stencil: spawn `stencil` with args (stdio: inherit)
Stencil->>OS: execute tests
Stencil-->>Runner: exit code or signal
alt exited with numeric code
Runner->>NPM: exit with same code
else terminated by signal
Runner->>OS: re-emit same signal
else other failure
Runner->>NPM: exit 1
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3788/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@scripts/run-tests.cjs`:
- Around line 11-18: The Windows runner fails because stencilBin points to
node_modules/.bin/stencil (a .cmd shim) which spawnSync cannot execute directly;
update the CLI resolution in scripts/run-tests.cjs by replacing the path-based
stencilBin with a cross-platform resolution using
require.resolve('@stencil/core/bin/stencil') and invoke it via process.execPath
(so spawnSync runs node with the resolved script), or alternatively keep
stencilBin but pass { shell: true } into the existing spawnSync call that uses
stencilBin; update references to stencilBin and the spawnSync invocation
accordingly (look for the stencilBin variable and the spawnSync call that runs
the Stencil CLI).
e825146 to
954cb88
Compare
…enabled Adds a test runner wrapper script that automatically enables verbose output when debug logging is enabled. The wrapper detects ACTIONS_STEP_DEBUG, RUNNER_DEBUG, or DEBUG env vars and adds the --verbose flag to the stencil test command.
954cb88 to
a77f57d
Compare
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Adds a test runner wrapper script that automatically enables verbose output when debug logging is enabled.
The wrapper detects ACTIONS_STEP_DEBUG, RUNNER_DEBUG, or DEBUG env vars and adds the --verbose flag to the stencil test command.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: