Add ability to append pid to the filename of the log dumping in ApiDump#2407
Open
zaiste-linganer wants to merge 2 commits intoLunarG:mainfrom
Open
Add ability to append pid to the filename of the log dumping in ApiDump#2407zaiste-linganer wants to merge 2 commits intoLunarG:mainfrom
zaiste-linganer wants to merge 2 commits intoLunarG:mainfrom
Conversation
|
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI VulkanTools build queued with queue ID 454259. |
|
CI VulkanTools build # 4578 running. |
|
CI VulkanTools build # 4578 passed. |
Contributor
Author
|
With the build working across all the targets, and testing done on Windows that it actually works as expected, can we get the final review? :) Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution for issue #2406.
Tested on Windows. Still to be tested on other OSes, but sending for the early review.
@charles-lunarg please have a look!