Skip to content

Conversation

@mateeullahmalik
Copy link
Collaborator

No description provided.

@roomote
Copy link

roomote bot commented Jan 26, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

This commit simplifies the signing approach by switching from ADR-36 to raw signing throughout the codebase. Key changes:

  • SignIndexB64 now signs the base64-encoded payload (indexB64) instead of the raw JSON string, aligning with how SignLayoutB64 works
  • Removed ADR-36 related functions (adr36SignerForKeyring, CreateSignaturesWithKeyringADR36WithSigner, CreateSignaturesWithKeyringADR36, SignADR36String)
  • BuildCascadeMetadataFromFile and GenerateStartCascadeSignatureFromFileWithSigner now use raw signing

Backward compatibility is maintained since VerifyIndex and VerifyStringRawOrADR36 already handle both raw and ADR-36 signature formats.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote[bot]
roomote bot previously approved these changes Jan 26, 2026
roomote[bot]
roomote bot previously approved these changes Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants