Skip to content

Conversation

@noellehmcheng
Copy link

No description provided.

@noellehmcheng
Copy link
Author

add a formation field parameter to replace the hardcoded formation field name

@noellehmcheng noellehmcheng marked this pull request as ready for review September 10, 2025 04:49
@rabii-chaarani
Copy link
Member

I don't understand why you added this field since there is unit field name already?

@noellehmcheng
Copy link
Author

I don't understand why you added this field since there is unit field name already?

in your code you wrote
geology = qgsLayerToGeoDataFrame(geology)
mask = ~geology['Formation'].astype(str).str.strip().isin(ignore_units)
geology = geology[mask].reset_index(drop=True)
you chose formation as the column to filter out units
did you want to use the column unitname instead?

@rabii-chaarani rabii-chaarani merged commit ebb88f0 into processing/processing_tools Sep 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants