3.3.0 #223
Merged
3.3.0 #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MapData) (#222) * sampler * fix extract_geology_contacts * fix calculate_fault_orientations and summarise_fault_data * fix dtm data type * fix get_value_from_raster import * style: style fixes by ruff and autoformatting by black * revert get_value_from_raster * move dtm and geology data parameters from sample function to constructor * Refactor contact extraction * refactor: update related method calls * refactor: simplify extract_basal_contacts method signature and logic * refactor: streamline contact extraction * refactor: update basal contacts references to use contact extractor * refactor: remove unused import of ContactExtractor * refactor: update basal contacts plotting to use contact extractor * refactor: refactor map2model wrapper to topology module * refactor: replace map2model with topology * test: add unit tests for Topology * refactor: update tests * remove self.map_data from topology class * fix variable naming * fix private attribute in topology --------- Co-authored-by: Noelle Cheng <noelle.cheng@monash.edu> Co-authored-by: noellehmcheng <143368485+noellehmcheng@users.noreply.github.com>
rabii-chaarani
changed the title
* refactor: remove MapData dependency from thickness calculators * refactor: update initialisation of thickness calculator * refactor: update tests * fix parameters pass to value_from_raster in thickness calculator * fix thickness calculator tests --------- Co-authored-by: Noelle Cheng <noelle.cheng@monash.edu>
noellehmcheng
approved these changes
Aug 13, 2025
rabii-chaarani
added a commit
that referenced
this pull request
Aug 13, 2025
This reverts commit 8590819.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… MapData) (#222)
sampler
fix extract_geology_contacts
fix calculate_fault_orientations and summarise_fault_data
fix dtm data type
fix get_value_from_raster import
style: style fixes by ruff and autoformatting by black
revert get_value_from_raster
move dtm and geology data parameters from sample function to constructor
Refactor contact extraction
refactor: update related method calls
refactor: simplify extract_basal_contacts method signature and logic
refactor: streamline contact extraction
refactor: update basal contacts references to use contact extractor
refactor: remove unused import of ContactExtractor
refactor: update basal contacts plotting to use contact extractor
refactor: refactor map2model wrapper to topology module
refactor: replace map2model with topology
test: add unit tests for Topology
refactor: update tests
remove self.map_data from topology class
fix variable naming
fix private attribute in topology
Description
📝 Thanks for contributing to map2loop!
Please describe the issue that this pull request addresses and summarize the changes you are implementing.
Include relevant motivation and context, if appropriate.
List any new dependencies that are required for this change.
Fixes #(issue)
Type of change
How Has This Been Tested?
Please describe any tests that you ran to verify your changes.
Provide branch name so we can reproduce.
Checklist:
Checklist continued (if PR includes changes to documentation)