feat: Add Overview page for empty pages - person version#7091
feat: Add Overview page for empty pages - person version#7091
Conversation
| if DateExt.isDefaultTimestamp(squadEntry.leavedate) and DateExt.isDefaultTimestamp(squadEntry.inactivedate) then | ||
| infoboxArgs.team = squadEntry.pagename | ||
| end |
There was a problem hiding this comment.
could this be added directly to LPDB query condition?
There was a problem hiding this comment.
no, we want the last squad entry for the player indep if still active or not
only the team value is depending on the squad entry still being active
id, name, flag, faction are not
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
| function EmptyPersonPagePreview:_getWiki() | ||
| if Logic.isNotEmpty(self.props.wiki) then | ||
| return self.props.wiki | ||
| end | ||
| if Logic.isNotEmpty(self.props.game) then | ||
| return Game.toIdentifier{game = self.props.game} or self.props.game | ||
| end | ||
| end |
There was a problem hiding this comment.
Is this needed? Infobox/Basic defaults to Info.wikiName for no input, which should be sufficient
There was a problem hiding this comment.
What is the difference on SC2?
There was a problem hiding this comment.
sc2 has infoboxes in different colors on the wiki
wol, hots, lotv, indicating the expansion of the game
this is used for infobox league, unit, building, ...
for players and teams it is always set to wol, but that is not the same as the fallback, which would be starcraft2
There was a problem hiding this comment.
I don't see a visual difference between wol and starcraft2 for player infoboxes
There was a problem hiding this comment.
it is a different blue:
There was a problem hiding this comment.
TBH that's not worth the extra code here, it's only quickview pages after all.
Or you move the hardcoded wol setting into the /custom for player infoboxes instead of setting it in the template.
There was a problem hiding this comment.
(Also, i'd question why players need the WOL color at all)
There was a problem hiding this comment.
opened a poll in sc2 channel about it:
https://discord.com/channels/93055209017729024/213614988647071744/1472932517471322186
Co-authored-by: SyntacticSalt <mail@mbergen.de>
Co-authored-by: SyntacticSalt <mail@mbergen.de>
Co-authored-by: SyntacticSalt <mail@mbergen.de>
3 participants
Summary
similar to #5966, just adding person specific version plus the wrapper which decides which of the 2 is called
How did you test this change?
dev