feat: new table widget by Eetwalt · Pull Request #7079 · Liquipedia/Lua-Modules

Eetwalt · 2026-02-11T08:55:35Z

Summary

This PR introduces the base for the new Table widget with the new designs.

Core features:

Column Schema: Define column properties (alignment, sizing, sorting) once; all cells inherit automatically
Smart Striping: Auto odd/even row coloring that intelligently respects rowspan for grouped rows
Native Sorting: MediaWiki sortable plugin integration with sort-type support
Theming: Light/dark mode variants (generic and themed)
Flexible Layouts: Support colspan/rowspan with automatic column index tracking
Auto-Detection: Header rows auto-detect title (first) vs column headers (subsequent rows)
Row highlighting (better design solution incoming at some point)
Horizontal scrolling when width exceeds available space
Manual Mediawiki tables can also be styled the same with class=table2__table

Open questions:

Naming: Named it Table2 for now to keep it isolated from other table modules. Eventually, this could be renamed to Table, once it's completely rolled out. Is this a good temporary name?
Utils: I made a ColumnUtil file in the Table2/ directory since it's utilities are relevant only for this widget. Even so, should the utilities live somewhere else or is the Table2 directory the right place?

Known limitations:

Hovering rows that have a column with rowspan only highlights the single row, not the whole rowgroup. Not sure if this is desired or not (I'd assume user expects the rowgroup to be highlighted, but not sure).
- Since rowspan usage is quite rare, I suggest this can be tackled at later point since I didn't find a quick and sensible fix to do this without introducing Javascript solution.

How did you test this change?

dev + dev tools
https://liquipedia.net/rainbowsix/User:Eetwalt
Test module:
https://liquipedia.net/commons/Module:Table2Test

TableFooter was never used in the codebase. Table2 uses the footer property on the Table widget instead, which wraps footer content in a div rather than using a dedicated widget. Changes: - Remove lua/wikis/commons/Widget/Table2/TableFooter.lua - Remove TableFooter import from lua/wikis/commons/Widget/Table2/All.lua All tests pass (417 successes).

- Remove wrapper-level styling props (wrapperClasses, wrapperCss, wrapperAttributes) - Remove table-level styling props (tableClasses, tableCss, tableAttributes) - Remove colspan/rowspan from Cell and CellHeader (never used) - Remove Table utility dependency from Cell and CellHeader - Consolidate props to single-level styling (classes, css, attributes on wrapper) - Reorder prop definitions: Structure → Behavior → Content → Styling - Reduces API complexity by 26% (9 props removed) - All 417 tests pass with no regressions

- Remove 'foot' from Table2SectionName alias (was defined but never used) - Remove foot handling logic from Row.lua (elseif for 'foot' section) - Remove unused sortClass and sortbottom CSS class logic - Table footer is rendered as a separate div in Table.lua, not as table rows - All 417 tests pass

- Cell and CellHeader were missing attributes = {} in defaultProps - This caused nil to be passed to HtmlWidgets.Td/Th when attributes weren't provided - HtmlWidgets expects attributes to be a table, not nil - Fixes 'bad argument to attr' error when rendering cells without explicit attributes - All 417 tests pass

- WidgetUtil.collect() is for flattening arrays/class lists, not for merging tables - Using it on attributes caused invalid table entries (arrays mixed with table pairs) - Changed to direct assignment: attributes['data-sort-type'] = props.sortType - This properly merges the sortType into the attributes table - Fixes 'bad argument to attr' error when rendering CellHeaders with sortType - All 417 tests pass

Copilot

Pull request overview

Introduces a new “Table2” widget foundation (Lua widgets + SCSS) to support updated table designs including column schemas, striping, sorting, and theming.

Changes:

Added Table2 widget components (Table, Header/Body, Row/Cell, and supporting contexts/utils).
Added SCSS styling for Table2 (light/dark surfaces, header/title, striping, theming).
Wired Table2 stylesheet into the main stylesheet bundle.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
stylesheets/commons/Table2.scss	New Table2 styling (surface, header/title, striping, themed variant).
stylesheets/Main.scss	Includes the new Table2 stylesheet in the build.
lua/wikis/commons/Widget/Table2/Table.lua	Main Table2 widget with optional column schema + sortable support.
lua/wikis/commons/Widget/Table2/TableHeader.lua	Header section that auto-classifies first header row as title vs columns.
lua/wikis/commons/Widget/Table2/TableBody.lua	Body section with “smart striping” that accounts for rowspan grouping.
lua/wikis/commons/Widget/Table2/Row.lua	Row widget applying section/kind/stripe/highlight classes and cell indexing.
lua/wikis/commons/Widget/Table2/Cell.lua	Body cell widget that inherits column schema props and applies sizing/classes.
lua/wikis/commons/Widget/Table2/CellHeader.lua	Header cell widget with inherited column schema props + sorting attributes.
lua/wikis/commons/Widget/Table2/CellIndexer.lua	Assigns implicit column indices per row, accounting for colspan.
lua/wikis/commons/Widget/Table2/ColumnUtil.lua	Utilities for validating/merging column defs and building css/classes.
lua/wikis/commons/Widget/Table2/ColumnContext.lua	Context provider for the column schema.
lua/wikis/commons/Widget/Table2/ColumnIndexContext.lua	Context provider for implicit column index propagation.
lua/wikis/commons/Widget/Table2/Section.lua	Context provider for section (“head” vs “body”) classification.
lua/wikis/commons/Widget/Table2/HeaderRowKind.lua	Context provider for header row kind (“title” vs “columns”).
lua/wikis/commons/Widget/Table2/BodyStripe.lua	Context provider for body stripe (“odd” vs “even”).
lua/wikis/commons/Widget/Table2/All.lua	Convenience exports for the Table2 widget set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lua/wikis/commons/Widget/Table2/CellIndexer.lua

lua/wikis/commons/Widget/Table2/ColumnUtil.lua

stylesheets/commons/Table2.scss

hjpalpha · 2026-02-12T16:01:27Z

runtime seems a bit better with the recent changes^^

Yeah quite minor though. I'm thinking if rendering 2k row tables is sensible thing to allow anyway for UX, or should we force pagination or something.

But since client-side pagination isn't useful for this and server-side pagination would be bad user experience so not sure if there's anything to do there

you have tables with hundreds of rows and way more columns
i just upped the row count as it was the easiest solution for producing large stuff
also keep in mind those tables will not necesarrily be the only things on the page

and fwiw i think the memory issue is the biggest problem

Eetwalt · 2026-02-12T18:01:19Z

Got it down a bit with the recent changes

Eetwalt · 2026-02-13T08:46:27Z

Getting rid of the column index context wrapper and doing the index setting in Row.lua seemed to do wonders. Down to ~30MB with the 2k rows test

lua/wikis/commons/Widget/Table2/BodyStripe.lua

stylesheets/commons/Table2.scss

lua/wikis/commons/Widget/Table2/BodyStripe.lua

Eetwalt · 2026-02-17T09:53:52Z

With the recent changes, mediawiki tables can also be styled the same with class=table2__table:

Before class=wikitable:

After class=table2__table:

lua/wikis/commons/Widget/Table2/Section.lua

lua/wikis/commons/Widget/Table2/ColumnContext.lua

lua/wikis/commons/Widget/Table2/Row.lua

Eetwalt added 27 commits February 5, 2026 16:10

first pass

45ea75c

no disallowed tags

1ee48c6

differentiate table header

c27332f

fix sorting

b732508

fix sorting v2

e83c91e

striped is default

d3d567d

sticky footer

96be64e

sticky title

48cc103

scroll by default

2aca9c0

cleanup

633b391

caption

2ddfb7b

css fixes

299d11c

add centralized column schema system

66b248e

fix assert

0eb5f3f

fix column context

cfaf2a0

improvements

66eaed3

cleanup

56cd3b9

bold footer

dad5464

rework striping to enable rowspan

83da76f

add highlighting

4aee875

rely on shrink class

0cb7193

cleanup

780a859

Copilot AI review requested due to automatic review settings February 11, 2026 08:55

Eetwalt added the stylesheets Changes to stylesheets label Feb 11, 2026

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Eetwalt added 6 commits February 12, 2026 18:50

optimize mergeProps

c9ac7ae

optimize cell indexer

537a325

perf test

d02baf2

util optimizations

387b748

indexer to inline

b3a67f9

cleanup

e42e1af

Eetwalt added 2 commits February 12, 2026 20:04

fix builder

8929e3c

lose columnindexcontext for performance test

4d0be7f

Eetwalt force-pushed the new-tables branch from 30f0d86 to 4d0be7f Compare February 13, 2026 13:09

Rathoz reviewed Feb 16, 2026

View reviewed changes

lua/wikis/commons/Widget/Table2/BodyStripe.lua Outdated Show resolved Hide resolved

Rathoz reviewed Feb 16, 2026

View reviewed changes

stylesheets/commons/Table2.scss Outdated Show resolved Hide resolved

Rathoz reviewed Feb 16, 2026

View reviewed changes

lua/wikis/commons/Widget/Table2/BodyStripe.lua Outdated Show resolved Hide resolved

Eetwalt added 3 commits February 17, 2026 08:51

use html elements instead of classes

e079881

remove asserts from context functions

d926287

use vars

922f65c

Rathoz reviewed Feb 17, 2026

View reviewed changes

lua/wikis/commons/Widget/Table2/BodyStripe.lua Outdated Show resolved Hide resolved

remove redundant function overrides

ada9d0e

Rathoz reviewed Feb 17, 2026

View reviewed changes

lua/wikis/commons/Widget/Table2/Section.lua Outdated Show resolved Hide resolved

consolidate contexts

8294093

Rathoz reviewed Feb 17, 2026

View reviewed changes

lua/wikis/commons/Widget/Table2/ColumnContext.lua Outdated Show resolved Hide resolved

Rathoz reviewed Feb 17, 2026

View reviewed changes

lua/wikis/commons/Widget/Table2/Row.lua Show resolved Hide resolved

Eetwalt added 2 commits February 17, 2026 16:53

remove table wrapper from columnContext

6693bf6

consolidate ColumnContext to Contexts/Table2

f18ce8e

Rathoz approved these changes Feb 17, 2026

View reviewed changes

Rathoz merged commit 6c29419 into main Feb 17, 2026
8 checks passed

Rathoz deleted the new-tables branch February 17, 2026 16:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new table widget#7079

feat: new table widget#7079
Rathoz merged 52 commits intomainfrom
new-tables

Eetwalt commented Feb 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hjpalpha commented Feb 12, 2026

Uh oh!

Eetwalt commented Feb 12, 2026

Uh oh!

Eetwalt commented Feb 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eetwalt commented Feb 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Eetwalt commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Open questions:

Known limitations:

How did you test this change?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hjpalpha commented Feb 12, 2026

Uh oh!

Eetwalt commented Feb 12, 2026

Uh oh!

Eetwalt commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eetwalt commented Feb 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Eetwalt commented Feb 11, 2026 •

edited

Loading

Eetwalt commented Feb 13, 2026 •

edited

Loading