Skip to content

feat(MatchTicker): Option to display MatchTicker from HDB#7034

Open
hjpalpha wants to merge 7 commits intomainfrom
matchticker-via-hdb
Open

feat(MatchTicker): Option to display MatchTicker from HDB#7034
hjpalpha wants to merge 7 commits intomainfrom
matchticker-via-hdb

Conversation

@hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Feb 3, 2026

Summary

requested on discord: https://discord.com/channels/93055209017729024/1445750345442656409/1467499566663340074

nydra giving green light for the idea: https://discord.com/channels/93055209017729024/1445750345442656409/1468152236067786855

As per discussions on discord:

  • if |matchticker=true is enabled in HDB it will (try to) display a matchticker
  • it only queries from current page and not from parent

How did you test this change?

dev
image
(placement of the matchticker obviously depends on the placement of HDB on the page)
the broken countdown is unrelated to this PR (seems to only be broken on that particular wiki ...)

Open Question:

do we want to allow input so that the matchticker can query form several tournaments?
(something like |matchTickerTournamentX=)
usage would be e.g. on https://liquipedia.net/geoguessr/GeoGuessr_World_Championship/2026/World_League/APAC where they display the matches of several subpages, but the page itself is a supgae of the tournament page too

@PiddyNydra

@hjpalpha hjpalpha requested review from a team February 3, 2026 10:52
@mbergen
Copy link
Collaborator

mbergen commented Feb 3, 2026

do we want to allow input so that the matchticker can query form several tournaments?
(something like |matchTickerTournamentX=)
usage would be e.g. on https://liquipedia.net/geoguessr/GeoGuessr_World_Championship/2026/World_League/APAC where they display the matches of several subpages, but the page itself is a supgae of the tournament page too

IMO not worth the effort. That page could just as well be a redirect, it does not display anything in addition to the transclusion/showbracket.

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Feb 3, 2026

do we want to allow input so that the matchticker can query form several tournaments?
(something like |matchTickerTournamentX=)
usage would be e.g. on https://liquipedia.net/geoguessr/GeoGuessr_World_Championship/2026/World_League/APAC where they display the matches of several subpages, but the page itself is a supgae of the tournament page too

IMO not worth the effort. That page could just as well be a redirect, it does not display anything in addition to the transclusion/showbracket.

tend to agree, just wanting to give nydra the option (since it is not hard to implement)

@hjpalpha hjpalpha added c: hidden_data_box c: match_ticker match2 based match ticker labels Feb 3, 2026
@Rathoz
Copy link
Collaborator

Rathoz commented Feb 12, 2026

Any reason to not always display this?

also CC @PiddyNydra

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Feb 12, 2026

Any reason to not always display this?

also CC @PiddyNydra

might be useless on some pages and increase runtime, but not opposed if wanted^^

@PiddyNydra
Copy link

Any reason to not always display this?
also CC @PiddyNydra

might be useless on some pages and increase runtime, but not opposed if wanted^^

Yeah, I was mostly concerned with the "uselessness" part, like, some sub-pages might have like 1 match on them

But also obviously not opposed to make it permanent.

@hjpalpha
Copy link
Collaborator Author

Any reason to not always display this?
also CC @PiddyNydra

might be useless on some pages and increase runtime, but not opposed if wanted^^

fwiw HDB is also run on matchpages (via MatchGroupInput.readMatchpage) to set the needed vars for the page
so for that one we would also get hdb trying to call the matchticker
it doesn't display, but iam not sure it is desired to run at all in that case

Copy link
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it merits to have an option to suppress matchticker display if explicitly requested

for instance, leagueoflegends:LCK/2026/Cup/Statistics page uses HDB to get page variables set up but this page trivially stores no match, so disabling matchticker query in pages like this would save some runtime&memory requirements

for clarity: I'm not opposed to having it enabled by default

@hjpalpha
Copy link
Collaborator Author

I think it merits to have an option to suppress matchticker display if explicitly requested

for instance, leagueoflegends:LCK/2026/Cup/Statistics page uses HDB to get page variables set up but this page trivially stores no match, so disabling matchticker query in pages like this would save some runtime&memory requirements

for clarity: I'm not opposed to having it enabled by default

should we supress it when calling it from match page?

…y it anyways, so just wasted runtime and memory)
Copy link
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


optional: should we short circuit in HiddenDataBox.run instead if args.supressMatchTicker is true? so something like

	if Logic.readBool(args.suppressMatchTicker) then
		return WarningBoxGroup{data = warnings}
	end
	return Fragment{children = WidgetUtil.collect(
		HiddenDataBox._matchTicker(Logic.readBool(args.supressMatchTicker)),
		WarningBoxGroup{data = warnings}
	)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: hidden_data_box c: match_ticker match2 based match ticker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants