Skip to content

feat(standings): add sdate/edate support to rounds#6923

Open
ElectricalBoy wants to merge 7 commits intomainfrom
standings-sdate-edate
Open

feat(standings): add sdate/edate support to rounds#6923
ElectricalBoy wants to merge 7 commits intomainfrom
standings-sdate-edate

Conversation

@ElectricalBoy
Copy link
Collaborator

Summary

Depends on #6920

This PR adds support for |sdate= and |edate= params for rounds in standings table.

How did you test this change?

dev

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

@ElectricalBoy
Copy link
Collaborator Author

why is this needed?

for allowing time-based round inputs like in old GTL/STLs
see leagueoflegends:User:ElectricalBoy/Sandbox as an example

@hjpalpha
Copy link
Collaborator

why is this needed?

for allowing time-based round inputs like in old GTL/STLs see leagueoflegends:User:ElectricalBoy/Sandbox as an example

i think that wasn't wanted for matches/games
why would we want it for rounds?

Base automatically changed from standings-use-tournamentstructure to main December 15, 2025 12:09
@ElectricalBoy
Copy link
Collaborator Author

i think that wasn't wanted for matches/games why would we want it for rounds?

https://discord.com/channels/93055209017729024/874304000718172200/1450022705641291857

@Eetwalt
Copy link
Collaborator

Eetwalt commented Jan 19, 2026

Will leave this be until Rath can take a look

@ElectricalBoy ElectricalBoy requested review from a team and removed request for Eetwalt and Rathoz February 3, 2026 04:10
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants