fix(client): remove redundant clone calls #2154

strmfos · 2025-12-25T15:40:25Z

Removed unnecessary .clone() and .to_string() calls in light-client where values were already owned.

Summary by CodeRabbit

Refactor
- Optimized internal code paths and error handling mechanisms.
- Improved efficiency through simplified value handling and removal of redundant operations across core modules.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-25T15:40:34Z

📝 Walkthrough

Walkthrough

Three source files are refactored to eliminate unnecessary clone operations and simplify ownership handling: error message construction in the indexer, token account field conversion, and RPC client network detection and transaction decoding.

Changes

Cohort / File(s)	Summary
Indexer Error Handling `sdk-libs/client/src/indexer/photon_indexer.rs`	Refactored fallback error message in `extract_result_with_error_check` to use `format!()` directly instead of calling `to_string()` on an already-formatted String
Type Conversions `sdk-libs/client/src/indexer/types.rs`	Changed `Into` implementation to move `token_account.account` directly instead of cloning when constructing `TokenDataWithMerkleContext`
RPC Client Optimizations `sdk-libs/client/src/rpc/client.rs`	Two micro-optimizations: (1) `detect_network` now moves string directly to `RpcUrl::Custom(url)` instead of cloning via `to_string()`, (2) removed unnecessary clone in decoded transaction extraction

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

fix: light-client error StateLookuptableNotFound #1872 — Related edits to the same code paths, particularly photon_indexer error handling and rpc/client's RpcUrl construction.

Suggested labels

ai-review

Suggested reviewers

sergeytimoshin
SwenSchaeferjohann

Poem

🔧 Clones once scattered, now they flee,
Ownership flows where it should be—
Three modest files, lean and bright,
Less copy, more right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 70.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: removing redundant clone calls throughout the light-client codebase. It matches the substantive changes across all three modified files.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3710030 and efcee9c.

📒 Files selected for processing (3)

sdk-libs/client/src/indexer/photon_indexer.rs
sdk-libs/client/src/indexer/types.rs
sdk-libs/client/src/rpc/client.rs

🧰 Additional context used

📓 Path-based instructions (1)

sdk-libs/**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

Unit tests in sdk-libs must not depend on light-test-utils; integration tests must be located in sdk-tests/

Files:

sdk-libs/client/src/indexer/types.rs
sdk-libs/client/src/indexer/photon_indexer.rs
sdk-libs/client/src/rpc/client.rs

🧠 Learnings (17)

📓 Common learnings

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: sdk-tests/sdk-ctoken-test/README.md:0-0
Timestamp: 2025-12-07T03:17:28.803Z
Learning: Applies to sdk-tests/sdk-ctoken-test/**/{lib,main}.rs : Clone AccountInfo structs when building CPI builder pattern account structs to avoid borrow checker issues

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/account-checks/docs/PACKED_ACCOUNTS.md:0-0
Timestamp: 2025-11-24T17:59:54.233Z
Learning: Applies to program-libs/account-checks/docs/program-libs/account-checks/src/**/*.rs : Provide descriptive names in ProgramPackedAccounts error messages (e.g., 'token_mint' instead of 'account')

📚 Learning: 2025-12-07T03:17:28.803Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: sdk-tests/sdk-ctoken-test/README.md:0-0
Timestamp: 2025-12-07T03:17:28.803Z
Learning: Applies to sdk-tests/sdk-ctoken-test/**/{lib,main}.rs : Clone AccountInfo structs when building CPI builder pattern account structs to avoid borrow checker issues

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:55:17.323Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: sdk-libs/macros/src/compressible/README.md:0-0
Timestamp: 2025-11-24T17:55:17.323Z
Learning: Applies to sdk-libs/macros/src/compressible/**/decompress_context.rs : Decompression trait implementation (`DecompressContext`) with account accessors, PDA/token separation logic, and token processing delegation should be in `decompress_context.rs`

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:55:17.323Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: sdk-libs/macros/src/compressible/README.md:0-0
Timestamp: 2025-11-24T17:55:17.323Z
Learning: Applies to sdk-libs/macros/src/compressible/**/variant_enum.rs : Account variant enum (`CompressedAccountVariant`) generation and `CompressedAccountData` wrapper struct should be implemented in `variant_enum.rs`

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-12-07T18:10:14.606Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: programs/compressed-token/program/CLAUDE.md:0-0
Timestamp: 2025-12-07T18:10:14.606Z
Learning: Applies to programs/compressed-token/program/src/ctoken_transfer.rs : CTokenTransfer instruction (discriminator: 3) must implement SPL-compatible transfers between decompressed accounts

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:59:36.701Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/account-checks/docs/DISCRIMINATOR.md:0-0
Timestamp: 2025-11-24T17:59:36.701Z
Learning: Applies to program-libs/account-checks/docs/**/account-checks/**/*.rs : Implement the Discriminator trait for account types, providing 8-byte LIGHT_DISCRIMINATOR constant and LIGHT_DISCRIMINATOR_SLICE reference in Rust account structures

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:56:00.229Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/batched-merkle-tree/docs/CLAUDE.md:0-0
Timestamp: 2025-11-24T17:56:00.229Z
Learning: Applies to program-libs/batched-merkle-tree/docs/**/Cargo.toml : Depend on light-compressed-account crate for compressed account types and utilities

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:59:23.357Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/account-checks/docs/CLAUDE.md:0-0
Timestamp: 2025-11-24T17:59:23.357Z
Learning: Applies to program-libs/account-checks/docs/src/**/*.rs : Use 8-byte discriminators for account type identification and implement the Discriminator trait for account identification

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:59:54.233Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/account-checks/docs/PACKED_ACCOUNTS.md:0-0
Timestamp: 2025-11-24T17:59:54.233Z
Learning: Applies to program-libs/account-checks/docs/program-libs/account-checks/src/**/*.rs : Provide descriptive names in ProgramPackedAccounts error messages (e.g., 'token_mint' instead of 'account')

Applied to files:

sdk-libs/client/src/indexer/types.rs
sdk-libs/client/src/indexer/photon_indexer.rs

📚 Learning: 2025-12-07T18:10:14.606Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: programs/compressed-token/program/CLAUDE.md:0-0
Timestamp: 2025-12-07T18:10:14.606Z
Learning: All compressed token account implementations must reference and comply with the account layout specifications in programs/compressed-token/program/docs/ACCOUNTS.md

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:56:00.229Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/batched-merkle-tree/docs/CLAUDE.md:0-0
Timestamp: 2025-11-24T17:56:00.229Z
Learning: Applies to program-libs/batched-merkle-tree/docs/**/Cargo.toml : Depend on light-zero-copy crate for zero-copy serialization for efficient account data access

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-12-07T03:17:28.803Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: sdk-tests/sdk-ctoken-test/README.md:0-0
Timestamp: 2025-12-07T03:17:28.803Z
Learning: Use compressible token account extensions that allow accounts to be compressed back into compressed state with rent payment mechanisms

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-12-07T18:10:14.606Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: programs/compressed-token/program/CLAUDE.md:0-0
Timestamp: 2025-12-07T18:10:14.606Z
Learning: Applies to programs/compressed-token/program/src/close_token_account.rs : Close token account instruction must return rent exemption to rent recipient if compressible and remaining lamports to destination account

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T17:57:39.230Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/batched-merkle-tree/docs/QUEUE_ACCOUNT.md:0-0
Timestamp: 2025-11-24T17:57:39.230Z
Learning: Applies to program-libs/batched-merkle-tree/docs/src/queue.rs : Validate account ownership by Light account compression program using `check_owner` from `light-account-checks` when deserializing `BatchedQueueAccount` with `output_from_account_info`

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-11-24T18:01:30.012Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:01:30.012Z
Learning: Run account-compression tests using `cargo test-sbf -p account-compression-test` to test core account compression program (Merkle tree management)

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-12-06T00:49:21.983Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/compressible/CLAUDE.md:0-0
Timestamp: 2025-12-06T00:49:21.983Z
Learning: Applies to program-libs/compressible/src/config.rs : CompressibleConfig account structure must support serialization via Anchor, Pinocchio, and Borsh formats for Light Registry program integration

Applied to files:

sdk-libs/client/src/indexer/types.rs

📚 Learning: 2025-12-06T00:49:21.983Z

Learnt from: CR
Repo: Lightprotocol/light-protocol PR: 0
File: program-libs/compressible/CLAUDE.md:0-0
Timestamp: 2025-12-06T00:49:21.983Z
Learning: Applies to program-libs/compressible/src/error.rs : Support ProgramError conversions for Anchor, Pinocchio, and Solana frameworks in error implementation

Applied to files:

sdk-libs/client/src/indexer/photon_indexer.rs

🔇 Additional comments (4)

sdk-libs/client/src/rpc/client.rs (2)

147-147: LGTM! Redundant string allocation removed.

Since url is already an owned String from self.client.url() (line 135) and isn't used after this point, moving it directly into RpcUrl::Custom is correct and avoids an unnecessary allocation.

237-241: LGTM! Unnecessary transaction clone removed.

The .clone() call was redundant here. Since decode() returns an owned value and the transaction isn't needed in its encoded form after this point, we can move the decoded transaction directly.

sdk-libs/client/src/indexer/types.rs (1)

951-956: LGTM! Redundant account clone eliminated.

Since into_iter() (line 950) gives us ownership of each token_account, we can move both token_account.token and token_account.account directly without cloning. This is consistent with how token is already being moved at line 953, and removes an unnecessary allocation.

sdk-libs/client/src/indexer/photon_indexer.rs (1)

141-141: LGTM! Redundant string conversion removed.

The format!() macro already returns a String, so calling .to_string() on its result was creating an unnecessary clone. This change eliminates that redundant allocation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

fix(client): remove redundant clone calls

efcee9c

strmfos requested review from SwenSchaeferjohann and sergeytimoshin as code owners December 25, 2025 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(client): remove redundant clone calls #2154

fix(client): remove redundant clone calls #2154

Uh oh!

strmfos commented Dec 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 25, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix(client): remove redundant clone calls #2154

Are you sure you want to change the base?

fix(client): remove redundant clone calls #2154

Uh oh!

Conversation

strmfos commented Dec 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

strmfos commented Dec 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 25, 2025 •

edited

Loading