Fix 15bpp handling across encoders #683
Open
+29
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the zrle encoding to use two bytes instead of one for 15bpp. Previously we would leave much of the output buffer uninitialized.
This fixes the trle encoding to use two bytes instead of one for 15bpp. Previously we would leave much of the output buffer uninitialized.
These are used to define a uint$REALBPP_t type, but REALBPP can be (e.g.) 15, and there generally is no uint15_t, so it never would have worked anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some incorrect rounding of division, the trle and zrle encoders erroneously used 1 byte for 15bpp formats instead of 2 bytes. This led to much of the output buffer being left uninitialized.
Note: this issue was discovered via #681.