Store Metadata as Values #99
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified feature extraction to use new FeatureExtractor interface.
Replaced list of features with FeatureExtractor. This allows the user to pass in a FeatureExtractor object with feature parameters + standardization.
Added offline regression example .md and .rst files. Also added link to this example in index.rst.
Main --> Develop
This reverts commit 353e286.
Class name was accidentally changed during a previous commit. Reverted so its name is more consistent with other classes.
Previous commit added a duplicate write_output method definition in OnlineStreamer.
Some time series models operate by predicting on a sequence of windows instead of raw EMG data. Added option to queue windows instead of just passing in a single window.
Feature queue parameter was in OnlineStreamer, but not the online classifier and regressor. Added documentation to those classes and implemented parameters to create models that feature queue.
Channels could not be isolated for online data. Added functionality to only grab certain channels online.
This reverts commit ec52763.
Rename ColumnFetch to ColumnFetcher
Offline Regression Example
Default value for regex helper function often threw an error when searching for a pattern. Replaced the default value with the wildcard, so users can use this to grab the potential values without knowing them.
Since the regex helper function can take None values, users may pass in None to RegexFilter. This wouldn't work since we store metadata as an index of the values they pass in. Added a check to ensure this doesn't happen.
Default value for regex helper function often threw an error when searching for a pattern. Replaced the default value with the wildcard, so users can use this to grab the potential values without knowing them.
Since the regex helper function can take None values, users may pass in None to RegexFilter. This wouldn't work since we store metadata as an index of the values they pass in. Added a check to ensure this doesn't happen.
Users could pass in function handles to change metadata operations, but there are some operations that are very common and require users to define function handles (like grabbing the last sample). Added ability to pass in strings for some common operations.
Add string parameters for common metadata operations
This reverts commit 19f2049.
Data could not be standardized online. Added a method to install standardization to online models.
eeddy
force-pushed
the
dataset_updates
branch
27 times, most recently
from
ceab009 to
371ea73
Compare
eeddy
force-pushed
the
latest
branch
2 times, most recently
from
e230a12 to
439358c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to this point we have stored metadata as the index in the list of potential values that the user passes in. This was done to reduce memory usage for things like strings. This can lead to confusing behaviour, particularly when isolating data (e.g., you want to isolate rep 2, but its index is 1 due to Python indexing).
These changes allow the user to store metadata as the values themselves instead of the indices. To avoid breaking previous code, the option to store as indices is still supported (and enabled by default).